Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support jsonExtension in LoadJobConfig #1751

Merged
merged 5 commits into from
Jan 12, 2024
Merged

feat: Support jsonExtension in LoadJobConfig #1751

merged 5 commits into from
Jan 12, 2024

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Dec 14, 2023

This PR:

  • Adds jsonExtension as a parameter to LoadJobConfig when loading data from a specified file format
  • It enable users to directly specify the extension within the job configuration and store that information in metadata
  • It allows BQ to Interpret the source format correctly (?)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [] Appropriate docs were updated (if necessary) (should autogenerate?)

Fixes #1581 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 14, 2023
@kiraksi
Copy link
Contributor Author

kiraksi commented Dec 19, 2023 •
edited
Loading

We are unable to find jsonExtension explicitly in LoadJobConfig BigQuery documentation, only some mentions of it. This PR is on hold until we can get clarity on this.

Edit: Was able to find jsonExtension, however its documentation was being suppressed as the person working on it left Google and did not unsurppress it. This was fix and the documentation was updated

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jan 11, 2024
@kiraksi kiraksi marked this pull request as ready for review January 11, 2024 05:02
@kiraksi kiraksi requested review from a team as code owners January 11, 2024 05:02
@kiraksi kiraksi removed the request for review from alvarowolfx January 11, 2024 18:29
chalmerlowe
chalmerlowe approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 0fd7347 into googleapis:main Jan 12, 2024
19 checks passed
@release-please release-please bot mentioned this pull request Jan 12, 2024
Merged
This was referenced Jan 17, 2024
Closed
Closed
Closed
@kiraksi kiraksi deleted the support-jsonextension branch January 17, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support jsonExtension in LoadJobConfig
2 participants
@kiraksi @chalmerlowe