feat: support RANGE in schema #1746
Conversation
product-auto-label
bot
added
size: m
Linchin
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
|
test failures seem to be api call timeout. |
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@shollyman After adding the system test, I also had to make a bunch of other changes. Please take another look, thank you :) |
| self._properties["type"] = element_type.upper() | ||
|
|
||
| @property | ||
| def element_type(self): |
There was a problem hiding this comment.
Do you also need a setter for this property? Or you're only exposing a setter from the containing type?
There was a problem hiding this comment.
I decided to not allow the element type to be altered in order to protect the table schema from being changed unintentionally. As a reference, most of the properties in class SchemaField don't have setters either.
tests/system/test_client.py
Outdated
| @@ -1804,6 +1799,11 @@ def test_dbapi_fetch_w_bqstorage_client_large_result_set(self): | |||
| ("id", 3), | |||
| ("timestamp", datetime.datetime(2006, 10, 9, 18, 40, 33, tzinfo=UTC)), | |||
| ], | |||
| [ | |||
There was a problem hiding this comment.
Not clear how the changes in this file relate to the feature. Just a side fixup?
There was a problem hiding this comment.
The expected value was changed because the public table somehow lost the first row of the table (id=1) around 12/31, so the system test has been failing.
I have also notified the team managing the public datasets.
part of #1724
FieldElementTypeto supportRANGEtype in schemaThank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: