Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deserializing JSON subfields within structs fails #1742

Merged
merged 13 commits into from
Dec 14, 2023
Merged

fix: Deserializing JSON subfields within structs fails #1742

merged 13 commits into from
Dec 14, 2023

Conversation

ericapetersson
Copy link
Contributor

@ericapetersson ericapetersson commented Dec 4, 2023 •
edited
Loading

… for deserializing json subfields from bigquery, this adds support for that.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1500 🦕

@ericapetersson
fix(Adding-support-to-dezerialize-json): currently there's no support…
e354860 
… for dezerialising json structures from bigquery, this adds support for that
@ericapetersson ericapetersson requested review from a team as code owners December 4, 2023 10:54
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 4, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 4, 2023
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@parthea
Copy link
Contributor

parthea commented Dec 8, 2023

@ericapetersson, Thanks for opening a PR! Please could you add tests to close the coverage gap?

Name                                                         Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------------------------
google/cloud/bigquery/_helpers.py                              296      3    154      0    99%   244-247

@parthea parthea changed the title fix(Adding-support-to-deserializing-json): currently there's no support… fix: Deserializing JSON subfields within structs fails Dec 8, 2023
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@parthea parthea assigned Linchin and unassigned ericapetersson Dec 8, 2023
@parthea parthea requested a review from Linchin December 8, 2023 15:11
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 8, 2023
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@tswast
Copy link
Contributor

tswast commented Dec 13, 2023

Thanks so much for the contribution @ericapetersson ! This fix has been merged in #1587

@tswast tswast closed this Dec 13, 2023
@vvkh vvkh mentioned this pull request Dec 14, 2023
Closed
@tswast tswast reopened this Dec 14, 2023
@tswast tswast added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0d93073 into googleapis:main Dec 14, 2023
18 of 20 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2023
@release-please release-please bot mentioned this pull request Dec 14, 2023
Merged
This was referenced Jan 17, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@mrfaizal mrfaizal Awaiting requested review from mrfaizal mrfaizal is a code owner automatically assigned from googleapis/api-bigquery

@Linchin Linchin Awaiting requested review from Linchin

Assignees

@Linchin Linchin

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericapetersson @parthea @tswast @Linchin @yoshi-kokoro