-
Notifications
You must be signed in to change notification settings - Fork 322
fix: load_table_from_dataframe for higher scale decimal #1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3573d3 to
d72d05e
Compare
269be64 to
aa343a0
Compare
628d53c to
7ca7abe
Compare
|
@Gaurang033 please fix the test failures |
bab1780 to
75f793f
Compare
could you help me understand which test is failing. I tried checking in logs but couldn't find much information. |
|
Hi @Gaurang033, thank you so much for your contribution, we really appreciate it. Just to make it more efficient for you in the future, you can see a rundown of all test results if you scroll down to the bottom of the logs (kokoro test especially): |
75f793f to
a750ee8
Compare
I am running coverge using following, however my result is different then I see in logs. |
a750ee8 to
c242634
Compare
f08394b to
a662beb
Compare
|
Thank you @Gaurang033 for fixing the coverage test :) |


Fixes #1650