Skip to content

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Oct 2, 2023

Follow-up to #1643

Fixes internal issue 302750597 🦕

@tswast tswast requested review from a team as code owners October 2, 2023 14:35
@tswast tswast requested a review from obada-ab October 2, 2023 14:35
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 2, 2023
@chalmerlowe
Copy link
Collaborator

This does not account for the fourth option that is available:

STORAGE_BILLING_MODEL_UNSPECIFIED

That should at least be called out in the comment.

@tswast
@Linchin

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 2, 2023
@tswast
Copy link
Contributor Author

tswast commented Oct 2, 2023

That should at least be called out in the comment.

Added!

IMO, the less client-side logic the better, but adding this in the docs makes sense to me.

@shollyman shollyman requested review from Linchin and chalmerlowe and removed request for obada-ab October 2, 2023 15:48
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 514d3e1 into main Oct 2, 2023
@tswast tswast deleted the b302750597-storage_billing_model branch October 2, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants