feat: add Model.transform_columns property
#1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
SalemJorden
changed the title
Model.transform_columns property
tswast
requested changes
Sep 22, 2023
google/cloud/bigquery/model.py
Outdated
| ] | ||
|
|
||
| @property | ||
| def transform_columns(self) -> Sequence[Dict[str, Any]]: |
Contributor
There was a problem hiding this comment.
Please make this return a sequence of your new TransformColumn objects instead of a sequence of dictionaries.
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
reviewed
Sep 27, 2023
…umn objects,updated test
…quence of dictionaries.
tswast
requested changes
Oct 10, 2023
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
TransformColumn is looking quite good now. A few more comments to address, please.
tswast
reviewed
Oct 11, 2023
tswast
reviewed
Oct 11, 2023
tests/unit/model/test_model.py
Outdated
| "name": "transform_name" , | ||
| "type": {"typeKind": "INT64"}, | ||
| "transformSql": "transform_sql" | ||
| }] |
Contributor
There was a problem hiding this comment.
Let's run "nox -r -s blacken" from the terminal to format this.
tswast
approved these changes
Oct 11, 2023
tswast
reviewed
Oct 11, 2023
tswast
added
automerge
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕