Skip to content

Conversation

@chalmerlowe
Copy link
Collaborator

Adds type annotations for three functions.

@tswast

Fixes #1605 🦕

@chalmerlowe chalmerlowe requested review from a team as code owners July 19, 2023 15:17
@chalmerlowe chalmerlowe requested a review from Neenu1995 July 19, 2023 15:17
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 19, 2023
@chalmerlowe
Copy link
Collaborator Author

The pre-release fails are due to an inconsistency between ms and ns with an upstream library. These fails are a known issue being addressed separately.

They should not affect the merge of this PR.

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the errors only appear with newer versions of mypy. Please create a tracking bug to upgrade mypy here:

MYPY_VERSION = "mypy==0.910"

@chalmerlowe
Copy link
Collaborator Author

Created a tracking bug to upgrade mypy.

#1614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type annotation incorrect for job_config argument(s)

2 participants