Skip to content

feat: add date, datetime, time, timestamp dtype to to_dataframe #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chelsea-lin merged 1 commit into from
Apr 18, 2023
Merged

feat: add date, datetime, time, timestamp dtype to to_dataframe #1547

chelsea-lin merged 1 commit into from
Apr 18, 2023

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Apr 7, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1546 🦕

@chelsea-lin chelsea-lin requested review from a team as code owners April 7, 2023 00:32
@chelsea-lin chelsea-lin requested a review from shollyman April 7, 2023 00:32
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Apr 7, 2023
@chelsea-lin chelsea-lin requested a review from tswast April 7, 2023 00:33
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_typesmapper branch from 3075ecd to ef363e4 Compare April 7, 2023 03:30
tswast
tswast requested changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it so far.

Would you do me a favor and add a system test with "extreme" values like this one, but instead of looking for "object" dtypes, we pass in the ArrowDtype?

python-bigquery/tests/system/test_pandas.py

Line 1063 in e1aa921

def test_list_rows_nullable_scalars_extreme_dtypes(

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_typesmapper branch from 5a8c0f6 to ac07193 Compare April 10, 2023 17:29
@chelsea-lin chelsea-lin requested a review from tswast April 10, 2023 17:30
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_typesmapper branch from ac07193 to f560802 Compare April 12, 2023 00:03
@chelsea-lin chelsea-lin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2023
tswast
tswast approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2023
@tswast tswast added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 13, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 13, 2023
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_typesmapper branch 3 times, most recently from c78c50f to e1f7f77 Compare April 18, 2023 05:31
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_typesmapper branch from 36f6878 to c9dbce3 Compare April 18, 2023 19:06
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_typesmapper branch from c9dbce3 to e321e14 Compare April 18, 2023 21:47
@chelsea-lin chelsea-lin enabled auto-merge (squash) April 18, 2023 21:47
@chelsea-lin chelsea-lin merged commit 64e913d into main Apr 18, 2023
@chelsea-lin chelsea-lin deleted the main_chelsealin_typesmapper branch April 18, 2023 22:14
@release-please release-please bot mentioned this pull request Apr 18, 2023
Merged
This was referenced Apr 25, 2023
Closed
Closed
Closed
@bnaul bnaul mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman was automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 'date_dtype', 'datetime_dtype', 'time_dtype' and 'timetamp_dtype' to the 'to_dataframe' APIs

4 participants

@chelsea-lin @tswast @parthea @yoshi-kokoro