Skip to content

Conversation

@nayaknishant
Copy link
Contributor

@nayaknishant nayaknishant commented Feb 9, 2023

Fixes b/243699249 🦕

@nayaknishant nayaknishant requested a review from a team February 9, 2023 01:28
@nayaknishant nayaknishant requested a review from a team as a code owner February 9, 2023 01:28
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 9, 2023
@shollyman shollyman requested review from chalmerlowe and removed request for Neenu1995 February 13, 2023 23:34
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit f832e7a into googleapis:main Feb 15, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…1491)

* adding ASCII support for external config

* adding tests for preserveAscii...

* adding tests for preserveAscii...

* changing 'False' to False

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants