Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add __str__ method to DatasetReference #1477

Merged
merged 8 commits into from
Jan 30, 2023
Merged

feat: add __str__ method to DatasetReference #1477

merged 8 commits into from
Jan 30, 2023

Conversation

Mattix23
Copy link
Contributor

@Mattix23 Mattix23 commented Jan 25, 2023 •
edited by tswast
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closes #1289
Closes #1288
🦕

@Mattix23 Mattix23 requested a review from a team January 25, 2023 20:54
@Mattix23 Mattix23 requested a review from a team as a code owner January 25, 2023 20:54
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 25, 2023
@Mattix23 Mattix23 enabled auto-merge (squash) January 26, 2023 14:55
@Mattix23 Mattix23 merged commit f32df1f into main Jan 30, 2023
@Mattix23 Mattix23 deleted the issue1289-str_method_datasetrefrence branch January 30, 2023 20:55
@release-please release-please bot mentioned this pull request Jan 30, 2023
Merged
@AdeelK93
Copy link

Thank you @Mattix23!

@Mattix23
Copy link
Contributor Author

Thank you @Mattix23!

No problem! 😄

This was referenced Feb 7, 2023
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@Mattix23 @gcf-owl-bot @abdelmegahedgoogle
feat: add __str__ method to DatasetReference (googleapis#1477)
2f1f5ff 
* feat: add __str__ method to DatasetReference

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add __str__ method to DatasetReference
3 participants
@Mattix23 @AdeelK93 @tswast