Skip to content

fix: Handle unhandled error in startResumableUpload_ #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddelgrosso1 merged 1 commit into from
Jul 9, 2024
Merged

fix: Handle unhandled error in startResumableUpload_ #2495

ddelgrosso1 merged 1 commit into from
Jul 9, 2024

Conversation

@cuyl
Copy link
Contributor

@cuyl cuyl commented Jul 5, 2024

  • Added error handling using stream.destroy
  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2494

@cuyl cuyl requested review from a team as code owners July 5, 2024 08:14
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jul 5, 2024
ddelgrosso1
ddelgrosso1 reviewed Jul 8, 2024
View reviewed changes
@cuyl
fix: Handle unhandled error in startResumableUpload_
bd95053 
* Added error handling using `stream.destroy`
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024
@ddelgrosso1
Copy link
Contributor

ddelgrosso1 commented Jul 9, 2024

Thank you for the contribution @cuyl, we appreciate it.

@ddelgrosso1 ddelgrosso1 merged commit d5257ba into googleapis:main Jul 9, 2024
@release-please release-please bot mentioned this pull request Jul 8, 2024
Merged
@kazimanzurrashid kazimanzurrashid mentioned this pull request Aug 2, 2024
Open
@dizzylilly dizzylilly mentioned this pull request Aug 3, 2024
Open
@FarrelBhagaskara FarrelBhagaskara mentioned this pull request Aug 7, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
@dizzylilly dizzylilly mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unhandled Error in startResumableUpload_ Function

3 participants

@cuyl @ddelgrosso1 @yoshi-kokoro