Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw timeout error when using jobs.query #1402

Merged
merged 6 commits into from
Sep 23, 2024
Merged

fix: throw timeout error when using jobs.query #1402

merged 6 commits into from
Sep 23, 2024

Conversation

alvarowolfx
Copy link
Contributor

Properly handle timeout when going thought the fast query path and jobs.queryAPI method.

Fixes #1399 🦕

@alvarowolfx alvarowolfx requested review from a team as code owners September 10, 2024 20:43
@alvarowolfx alvarowolfx requested review from hongalex, shollyman and leahecole and removed request for hongalex September 10, 2024 20:43
@alvarowolfx alvarowolfx mentioned this pull request Sep 10, 2024
Closed
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Sep 10, 2024
leahecole
leahecole requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super small stuff, mostly questions and hardening up tests

src/bigquery.ts Show resolved Hide resolved
src/bigquery.ts Show resolved Hide resolved
src/bigquery.ts Show resolved Hide resolved
system-test/bigquery.ts Show resolved Hide resolved
system-test/bigquery.ts Show resolved Hide resolved
src/bigquery.ts Show resolved Hide resolved
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2024
@alvarowolfx alvarowolfx requested a review from a team as a code owner September 23, 2024 16:18
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2024
@alvarowolfx alvarowolfx merged commit cf962a5 into googleapis:main Sep 23, 2024
15 checks passed
@release-please release-please bot mentioned this pull request Sep 23, 2024
Merged
This was referenced Oct 1, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several issues with stateless queries
2 participants
@alvarowolfx @leahecole