Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not override queryParameters if params not informed #1359

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: should not override queryParameters if params not informed #1359

merged 1 commit into from
Apr 26, 2024

Conversation

alvarowolfx
Copy link
Contributor

Fixes #1357 🦕

@alvarowolfx alvarowolfx requested review from a team as code owners April 25, 2024 17:52
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 25, 2024
@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: s Pull request size is small. labels Apr 25, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Apr 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2024
@alvarowolfx alvarowolfx requested review from shollyman, leahecole and feywind and removed request for chalmerlowe April 25, 2024 17:53
@stefandoorn stefandoorn mentioned this pull request Apr 26, 2024
Closed
@alvarowolfx alvarowolfx merged commit 2b66d1e into googleapis:main Apr 26, 2024
15 checks passed
@release-please release-please bot mentioned this pull request Apr 26, 2024
Merged
This was referenced Apr 30, 2024
Closed
Closed
Closed
@WontonSam WontonSam mentioned this pull request Jul 17, 2024
Open
@Pyloris Pyloris mentioned this pull request Jul 31, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 20, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@leahecole leahecole Awaiting requested review from leahecole

@feywind feywind Awaiting requested review from feywind

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct usage of queryParameters broke with 7.6.0
2 participants
@alvarowolfx @shollyman