feat: update types and generation script #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shollyman
approved these changes
Feb 15, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
LGTM. Is it worth filing a FR to push the escaping logic down into the template processor, or is discovery-tsd not long for this world here?
Contributor
Author
I'll create an issue on the |
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update types generation script to handle new Discovery changes and handle a case where the
discovery-tsdtool doen't handle fields with dots, likeformatOptions.useInt64Timestamp.Also regenerate types with latest changes.