feat: add support for TPC Universes #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
alexander-fenster
approved these changes
Feb 8, 2024
danielbankhead
approved these changes
Feb 8, 2024
danielbankhead
left a comment
danielbankhead
left a comment
There was a problem hiding this comment.
LGTM, a few optional comments.
| */ | ||
| export class BigQuery extends Service { | ||
| location?: string; | ||
| private _universeDomain: string; |
There was a problem hiding this comment.
You can also use:
Suggested change
| private _universeDomain: string; | |
| #universeDomain: string; |
To make it truly private.
| }); | ||
| } | ||
|
|
||
| get universeDomain() { |
There was a problem hiding this comment.
Note: In the future we may want to check via Auth’s universe domain getter; which is async.
alvarowolfx
commented
Feb 8, 2024
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards internal b/311238858