Skip to content

feat: Add totalSlotMs to JobStatistics #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PhongChuong merged 3 commits into from
Apr 19, 2024
Merged

feat: Add totalSlotMs to JobStatistics #3250

PhongChuong merged 3 commits into from
Apr 19, 2024

Conversation

@PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Apr 18, 2024 •
edited
Loading

This PR moves QueryStatistics.getTotalMs() to the super class JobStatistics.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3249 ☕️

@PhongChuong PhongChuong requested a review from a team as a code owner April 18, 2024 18:53
@PhongChuong PhongChuong requested a review from leahecole April 18, 2024 18:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Apr 18, 2024
@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 18, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 18, 2024
@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 19, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 19, 2024
@PhongChuong PhongChuong requested a review from shollyman April 19, 2024 18:29
shollyman
shollyman approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

Its a master class in semantic satiation for the word "slot". :)

@PhongChuong
Copy link
Contributor Author

PhongChuong commented Apr 19, 2024

Thanks for the review.

@PhongChuong PhongChuong merged commit 75ea095 into main Apr 19, 2024
@PhongChuong PhongChuong deleted the totalSlotMs branch April 19, 2024 19:10
@release-please release-please bot mentioned this pull request Apr 19, 2024
Merged
This was referenced Apr 30, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

@leahecole leahecole Awaiting requested review from leahecole leahecole is a code owner automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add totalSlotMs to JobStatistics

3 participants

@PhongChuong @shollyman @yoshi-kokoro