Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getDouble in read API path #2919

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix: getDouble in read API path #2919

merged 2 commits into from
Oct 3, 2023

Conversation

obada-ab
Copy link
Member

@obada-ab obada-ab commented Oct 2, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2905 ☕️

@obada-ab obada-ab requested a review from a team as a code owner October 2, 2023 12:11
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Oct 2, 2023
@obada-ab obada-ab changed the title Fix: getDouble in read API path fix: getDouble in read API path Oct 2, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 2, 2023 12:13
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 2, 2023
@obada-ab obada-ab added the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 436ee8e into main Oct 3, 2023
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the resultset-getdouble branch October 3, 2023 08:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@release-please release-please bot mentioned this pull request Oct 11, 2023
Merged
This was referenced Oct 17, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995 Neenu1995 is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQueryResultImpl.getDouble throws ClassCastException if read API is used
2 participants
@obada-ab @shollyman