Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for converting interval fields to threeten PeriodDuration #2838

Merged
merged 6 commits into from
Sep 6, 2023

Conversation

obada-ab
Copy link
Member

@obada-ab obada-ab commented Aug 4, 2023

Add support for converting BigQuery interval type to threeten PeriodDuration, information about the canonical interval form can be found here. Parsing logic was referenced from here.

Fixes #1849 ☕️

@obada-ab obada-ab requested a review from a team as a code owner August 4, 2023 15:12
@obada-ab obada-ab requested a review from shollyman August 4, 2023 15:12
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Aug 4, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner August 4, 2023 15:13
@obada-ab obada-ab added the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
@gcf-merge-on-green
Copy link

Your PR has conflicts that you need to resolve before merge-on-green can automerge

@gcf-merge-on-green gcf-merge-on-green bot merged commit 2294c2f into main Sep 6, 2023
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the support-for-periodduration branch September 6, 2023 13:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to convert Interval type input from canonical/ISO 8610 format to treeten-extra PeriodDuration
2 participants