Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reference file schema option for federated formats #2269

Merged
merged 19 commits into from
Sep 12, 2022
Merged

feat: add reference file schema option for federated formats #2269

merged 19 commits into from
Sep 12, 2022

Conversation

Neenu1995
Copy link
Contributor

No description provided.

@Neenu1995 Neenu1995 requested review from a team and shollyman September 9, 2022 17:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Sep 9, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@Neenu1995 Neenu1995 requested a review from a team as a code owner September 9, 2022 18:03
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 9, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
shollyman
shollyman reviewed Sep 12, 2022
View reviewed changes
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ExternalTableDefinition.java Outdated
@@ -317,6 +328,15 @@ com.google.api.services.bigquery.model.ExternalDataConfiguration toExternalDataC
if (getAutodetect() != null) {
externalConfigurationPb.setAutodetect(getAutodetect());
}
if (FormatOptions.AVRO.equals(getFormatOptions().getType())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a philosophical question here around enforcing logic in the client versus just propagating what the user sets. Generally we've favored allowed the backend to evaluate these kinds of things.

Copy link
Contributor Author

@Neenu1995 Neenu1995 Sep 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java Outdated
Job job = bigquery.create(JobInfo.of(loadJobConfiguration));
// Blocks until this load table job completes its execution, either failing or succeeding.
job = job.waitFor();
if (job.isDone()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic seems odd (here and in the other variants). A job can be done with or without an error attached. you can just assert the job completed without errors?

Also, as this doesn't appear to be a sample it's not clear what emitting to system.out is getting you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Neenu1995 Neenu1995 requested a review from shollyman September 12, 2022 18:23
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
shollyman
shollyman approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Neenu1995 Neenu1995 merged commit 8c488e6 into main Sep 12, 2022
@Neenu1995 Neenu1995 deleted the federated-format branch September 12, 2022 19:48
@release-please release-please bot mentioned this pull request Sep 12, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 12, 2022
@release-please
chore(main): release 2.16.0 (#2255)
0700ea3 
🤖 I have created a release *beep* *boop*
---


## [2.16.0](v2.15.0...v2.16.0) (2022-09-12)


### Features

* Add preserveAsciiControlCharacters to CsvOptions ([#2143](#2143)) ([856893f](856893f))
* Add reference file schema option for federated formats ([#2269](#2269)) ([8c488e6](8c488e6))


### Bug Fixes

* Socket-timeout at bigquery.it.ITNightlyBigQueryTest: testForTableNotFound ([#2260](#2260)) ([a9b5fb2](a9b5fb2))


### Dependencies

* Update dependency com.google.apis:google-api-services-bigquery to v2-rev20220827-2.0.0 ([#2261](#2261)) ([3c67d21](3c67d21))
* Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.9.3 ([#2259](#2259)) ([5e30a04](5e30a04))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#2267](#2267)) ([8472fe5](8472fe5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 20, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neenu1995 @shollyman @yoshi-kokoro