-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery/storage/managedwriter/adapt): add RANGE support to adapt #9836
feat(bigquery/storage/managedwriter/adapt): add RANGE support to adapt #9836
Conversation
This PR adds support for schema conversions and proto conversions to the adapt subpackage. For proto conversion, we build a static name for range message types rather than using the normal first-encountered-message, as the schema for a range field will also be the consistent for a given element type. This PR also moves adapt to using subtests for table-driven testing to make it easier to isolate specific test cases.
The interesting question here is how to register the message types for the range values when converting a table schema to the descriptor proto. At a high level, there's three options:
|
🤖 I have created a release *beep* *boop* --- ## [1.61.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.60.0...bigquery/v1.61.0) (2024-04-24) ### Features * **bigquery/storage/managedwriter/adapt:** Add RANGE support to adapt ([#9836](https://togithub.com/googleapis/google-cloud-go/issues/9836)) ([ae25253](https://togithub.com/googleapis/google-cloud-go/commit/ae252533375b21dd41a0ea13e85462bbcad291af)) * **bigquery:** RANGE support for basic data movement ([#9762](https://togithub.com/googleapis/google-cloud-go/issues/9762)) ([07f0806](https://togithub.com/googleapis/google-cloud-go/commit/07f0806a945c2cf0fbc431b63d9c8a30ed3a22fd)) * **bigquery:** RANGE support when reading Arrow format ([#9795](https://togithub.com/googleapis/google-cloud-go/issues/9795)) ([da245fa](https://togithub.com/googleapis/google-cloud-go/commit/da245fac5ee335e86c63bfa5f165b0ab84960847)) * **bigquery:** RANGE type StandardSQLDataType support ([#9754](https://togithub.com/googleapis/google-cloud-go/issues/9754)) ([33666cf](https://togithub.com/googleapis/google-cloud-go/commit/33666cfeaefdebc474045894af069ca7172e836b)) ### Bug Fixes * **bigquery/datatransfer:** Mark parent/name fields with the REQUIRED field_behavior annotation ([8892943](https://togithub.com/googleapis/google-cloud-go/commit/8892943b169060f8ba7be227cd65680696c494a0)) * **bigquery:** Bump x/net to v0.24.0 ([ba31ed5](https://togithub.com/googleapis/google-cloud-go/commit/ba31ed5fda2c9664f2e1cf972469295e63deb5b4)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This PR adds support for schema conversions and proto conversions to the adapt subpackage. For proto conversion, we build a static name for range message types rather than using the normal first-encountered-message, as the schema for a range field will also be the consistent for a given element type.
This PR also moves adapt to using subtests for table-driven testing to make it easier to isolate specific test cases.
Towards: #9017