fix(bigquery/storage/managedwriter): automatic retry for multiplex test #8601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In googleapis#8599 we caught a flake related to DeadlineExceeded errors. This class of error is retriable, so we set the EnableWriteRetries option when constructing writers to address this. The DE was likely raised from the service side, as in this case the test ran for ~32s (deadline is 90) and normal execution time should be sub-10s. This is also borne out by the problematic writes, which were both destined for the same table. Fixes: googleapis#8599
product-auto-label
bot
added
size: xs
alvarowolfx
approved these changes
Sep 21, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
🤖 I have created a release *beep* *boop* --- ## [1.56.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.55.0...bigquery/v1.56.0) (2023-10-05) ### Features * **bigquery/analyticshub:** Add Subscription resource and RPCs ([#8612](https://togithub.com/googleapis/google-cloud-go/issues/8612)) ([9992249](https://togithub.com/googleapis/google-cloud-go/commit/999224951d586513bd382483326b455c953a14f3)) * **bigquery:** Add external dataset reference ([#8545](https://togithub.com/googleapis/google-cloud-go/issues/8545)) ([1001acf](https://togithub.com/googleapis/google-cloud-go/commit/1001acf6ac894a7d9945b7d204ad55aa7b162909)) * **bigquery:** Add media options to LoadConfig ([#8640](https://togithub.com/googleapis/google-cloud-go/issues/8640)) ([62baf56](https://togithub.com/googleapis/google-cloud-go/commit/62baf569c052a8c565710533ba50a1f5df8176dd)) ### Bug Fixes * **bigquery/storage/managedwriter:** Automatic retry for multiplex test ([#8601](https://togithub.com/googleapis/google-cloud-go/issues/8601)) ([6ef1945](https://togithub.com/googleapis/google-cloud-go/commit/6ef1945a837430afcd195affd661768817cdc40b)) * **bigquery:** Dependency detection on proto conversion ([#8566](https://togithub.com/googleapis/google-cloud-go/issues/8566)) ([763ab5d](https://togithub.com/googleapis/google-cloud-go/commit/763ab5dbd466fd0450dcd46e38c75e87cbf6c49c)) ### Documentation * **bigquery/datatransfer:** Update transferConfig.name description to indicate that it supports both formats ([0449518](https://togithub.com/googleapis/google-cloud-go/commit/0449518f8396cc0280c0f3303c103edcee34016b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8599 we caught a flake related to DeadlineExceeded errors. This class of error is retryable, so we set the EnableWriteRetries option when constructing writers to address this.
The DE was likely raised from the service side, as in this case the test ran for ~32s (deadline is 90) and normal execution time should be sub-10s. This is also borne out by the problematic writes, which were both destined for the same table.
Fixes: #8599