Skip to content

Conversation

@noahdietz
Copy link
Contributor

Manually copies default retry configuration from the GAPIC WriteLogEntries default call options to be used as the default retry logic for the loggerRetryer. This is what I assume was intended in #7509, but which was not actually done, resulting in the nil panics reported by users (as the defaultRetryer was an uninitialized interface).

Fixes #8408

@noahdietz noahdietz requested review from a team as code owners August 14, 2023 19:25
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the Cloud Logging API. labels Aug 14, 2023
@noahdietz noahdietz merged commit c980708 into googleapis:main Aug 14, 2023
@noahdietz noahdietz deleted the logging-retryer branch August 14, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logging: panic: runtime error: invalid memory address or nil pointer dereference

2 participants