fix(bigquery): respect context during query execution #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates query polling and insertion to better respect context status. Fast path query insertion involves an RPC that allows server-side polling before returning, and waiting for jobs/queries is inherently something that can take extended time and should respect context. Fixes: googleapis#7604
product-auto-label
bot
added
size: m
codyoss
reviewed
Apr 5, 2023
product-auto-label
bot
added
size: s
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates query polling and insertion to better respect context status. Key change is to push context to the discovery library, but there are some small refactors to make use of context passing more consistent at various callsites.
Fixes: #7604