Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): empty slice instead of nil slice for primitive repeated fields #7315

Merged
merged 8 commits into from
May 17, 2024
Merged

fix(bigquery): empty slice instead of nil slice for primitive repeated fields #7315

merged 8 commits into from
May 17, 2024

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Jan 26, 2023 •
edited
Loading

BigQuery translates a NULL array into an empty array in the query result, although inside the query, NULL and empty arrays are two distinct values. This change brings the translation on the Go side more similar to the BQ backend. More on: https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#array_nulls

Resolves #4950 #9383

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 26, 2023
@alvarowolfx alvarowolfx changed the title fix!: empty slice instead of nil slice for primitive repeated fields fix(bigquery)!: empty slice instead of nil slice for primitive repeated fields Jan 27, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 27, 2023
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Feb 26, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Mar 28, 2023
@proost
Copy link

proost commented Jun 24, 2023 •
edited
Loading

@alvarowolfx do you have any progress?

@alvarowolfx alvarowolfx mentioned this pull request Feb 16, 2024
Closed
@alvarowolfx alvarowolfx changed the title fix(bigquery)!: empty slice instead of nil slice for primitive repeated fields fix(bigquery): empty slice instead of nil slice for primitive repeated fields May 13, 2024
@alvarowolfx alvarowolfx marked this pull request as ready for review May 13, 2024 18:50
@alvarowolfx alvarowolfx requested review from a team as code owners May 13, 2024 18:50
@alvarowolfx alvarowolfx added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
shollyman
shollyman approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is straightforward. We provide the most substantive guidance about value handling https://pkg.go.dev/cloud.google.com/go/bigquery#RowIterator.Next, is there anything you think we should include there to clarify this behavior?

@alvarowolfx
Copy link
Contributor Author

The change itself is straightforward. We provide the most substantive guidance about value handling https://pkg.go.dev/cloud.google.com/go/bigquery#RowIterator.Next, is there anything you think we should include there to clarify this behavior?

I added more information on that section about empty vs null arrays, do you think looks good ?

@alvarowolfx alvarowolfx merged commit b371210 into googleapis:main May 17, 2024
8 checks passed
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 22, 2024
@release-please
chore(main): release bigquery 1.62.0 (#10198)
74fd3b3 
🤖 I have created a release *beep* *boop*
---


## [1.62.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.61.0...bigquery/v1.62.0) (2024-07-22)


### Features

* **bigquery/analyticshub:** Support Direct Table Access Toggle (Egress GA) ([b660d68](https://togithub.com/googleapis/google-cloud-go/commit/b660d6870658fe6881883785bcebaea0929fec0a))
* **bigquery/analyticshub:** Support public directory self service for Listings/Exchanges ([#10485](https://togithub.com/googleapis/google-cloud-go/issues/10485)) ([b660d68](https://togithub.com/googleapis/google-cloud-go/commit/b660d6870658fe6881883785bcebaea0929fec0a))
* **bigquery:** Add rounding mode to FieldSchema ([#10328](https://togithub.com/googleapis/google-cloud-go/issues/10328)) ([1a9e204](https://togithub.com/googleapis/google-cloud-go/commit/1a9e204d7752c5bfe9edfd7bc7ee36c5b1385783))
* **bigquery:** Json support on managedwriter/adapt pkg ([#10542](https://togithub.com/googleapis/google-cloud-go/issues/10542)) ([978d4a1](https://togithub.com/googleapis/google-cloud-go/commit/978d4a1e47cbd8d4bf567b616381a2f12fac4cab))
* **bigquery:** Support column name character map in load jobs ([#10425](https://togithub.com/googleapis/google-cloud-go/issues/10425)) ([b829327](https://togithub.com/googleapis/google-cloud-go/commit/b82932789af82b5e0799c20a096aab98132b5eb1))


### Bug Fixes

* **bigquery/storage/managedwriter:** Faster context failure on send ([#10169](https://togithub.com/googleapis/google-cloud-go/issues/10169)) ([1fb0e64](https://togithub.com/googleapis/google-cloud-go/commit/1fb0e6401d584bf8ede60a170b4d82dc211010b8))
* **bigquery:** Bump google.golang.org/[email protected] ([8fa9e39](https://togithub.com/googleapis/google-cloud-go/commit/8fa9e398e512fd8533fd49060371e61b5725a85b))
* **bigquery:** Bump google.golang.org/[email protected] ([8ecc4e9](https://togithub.com/googleapis/google-cloud-go/commit/8ecc4e9622e5bbe9b90384d5848ab816027226c5))
* **bigquery:** Empty slice instead of nil slice for primitive repeated fields ([#7315](https://togithub.com/googleapis/google-cloud-go/issues/7315)) ([b371210](https://togithub.com/googleapis/google-cloud-go/commit/b3712100831061fea8605e574d482d7f768ecf14))
* **bigquery:** Reduce default backoffs ([#10558](https://togithub.com/googleapis/google-cloud-go/issues/10558)) ([037e9ef](https://togithub.com/googleapis/google-cloud-go/commit/037e9efa929ad9f8d6f725b28ec8096c3e536b76))


### Documentation

* **bigquery/analyticshub:** A comment for message `DataExchange` is changed ([b660d68](https://togithub.com/googleapis/google-cloud-go/commit/b660d6870658fe6881883785bcebaea0929fec0a))
* **bigquery/analyticshub:** A comment for message `Listing` is changed ([b660d68](https://togithub.com/googleapis/google-cloud-go/commit/b660d6870658fe6881883785bcebaea0929fec0a))
* **bigquery/datatransfer:** Update OAuth links in `CreateTransferConfigRequest` and `UpdateTransferConfigRequest` ([3df3c04](https://togithub.com/googleapis/google-cloud-go/commit/3df3c04f0dffad3fa2fe272eb7b2c263801b9ada))
* **bigquery:** Improve Inserter and StructSaver godoc ([#10170](https://togithub.com/googleapis/google-cloud-go/issues/10170)) ([c1cffb6](https://togithub.com/googleapis/google-cloud-go/commit/c1cffb63c33ae49f3a705bd0bc7a32cd2b0319bc))
* **bigquery:** Update description of query preview feature ([#10554](https://togithub.com/googleapis/google-cloud-go/issues/10554)) ([25c5cbe](https://togithub.com/googleapis/google-cloud-go/commit/25c5cbe6f31d62fdea1455889ac2e336d1287615))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Jul 30, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery: inconsistency in handling of repeated nested values and repeated values in valueMap
4 participants
@alvarowolfx @proost @shollyman @kokoro-team