fix(logging): fix stdout log http request format #7083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
losalex
approved these changes
Nov 18, 2022
Contributor
losalex
left a comment
losalex
left a comment
There was a problem hiding this comment.
LGTM - please also run this E2E in GCP to make sure it works as expected
|
@daniel-sanche thanks for fixing this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug when using standard out logs with http request objects, where the http objects were being output using snake_case names instead of mixedCase. This caused the GCP Logging parser to not detect the objects as http_request types, and dump the data in the main JSON payload instead.
After this fix, these logs should appropriately parse http request objects, and put the data in the httpRequest metadata field as expected.
Related environment test changes: googleapis/env-tests-logging#95
Fixes: #6391