feat(bigquery): remove code for reservation/apiv1beta1 #7010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source protos were removed for this API, best to remove the gapic too. See: googleapis/googleapis@54f1157
product-auto-label
bot
added
size: xl
alvarowolfx
reviewed
Nov 10, 2022
Contributor
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
I think this folder also needs to be removed:
internal/generated/snippets/bigquery/reservation/apiv1beta1
Out of curiosity, the changes that you made here are automated or manual ?
|
Here is the summary of changes. You are about to delete 19 region tags.
This comment is generated by snippet-bot.
|
Member
Author
|
@alvarowolfx Good catch, this change is manual. |
alvarowolfx
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source protos were removed for this API, best to remove the gapic too.
See: googleapis/googleapis@54f1157