fix(bigquery/storage/managedwriter): fix incorrect error retention #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failures for an individual append can get retained as the terminal error for the stream. Redact the logic responsible, and add a test that validates the correct behavior using context-based errors.
product-auto-label
bot
added
size: s
shollyman
requested review from
aribray and
alvarowolfx
and removed request for
aribray
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failures for an individual append can get retained as the terminal error for the stream. Redact the logic responsible, and add a test that validates the correct behavior using context-based errors.
Fixes: #6657