Skip to content

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 19, 2022

This PR:

  • augments the package docs with information on error handling
  • adds an integration test demonstrating use of StorageError details.

Fixes: #6321

This PR augments the package docs, as well as adding a utility
function for extracting an instance of the service's specific error
proto from an error (by way of the grpc status error details).

Fixes: googleapis#6321
@shollyman shollyman requested a review from a team July 19, 2022 04:34
@shollyman shollyman requested a review from a team as a code owner July 19, 2022 04:34
@shollyman shollyman requested a review from prash-mi July 19, 2022 04:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Jul 19, 2022
@shollyman shollyman requested review from yirutang and removed request for prash-mi July 19, 2022 04:34
@shollyman shollyman requested a review from codyoss July 19, 2022 15:43
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@shollyman
Copy link
Contributor Author

This needs some refactoring, but I want to get googleapis/gax-go#212 resolved to unblock this work.

@shollyman
Copy link
Contributor Author

Changes landed in gax, backed out the utility method in favor of leveraging the new ExtractProtoMessage() added to apierror.

@shollyman shollyman requested a review from quartzmo August 8, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigquery: storage/managedwriter: wrong error at the wrong place for large batch inserts

3 participants