Skip to content

perf(spanner): better error handling #10734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 6 commits into from
Sep 25, 2024
Merged

perf(spanner): better error handling #10734

gcf-merge-on-green merged 6 commits into from
Sep 25, 2024

Conversation

@egonelbre
Copy link
Contributor

@egonelbre egonelbre commented Aug 22, 2024 •
edited
Loading

  • perf(spanner): avoid using fmt.Errorf unnecessarily
  • perf(spanner): avoid duplicated errors.New in UnmarshalJSON
  • fix(spanner): error strings should not be capitalized

Updates #9749

@egonelbre
perf(spanner): avoid using fmt.Errorf unnecessarily
804fee8 
Fixed automatically with:

  go fmt -w -r "fmt.Errorf(s) -> errors.New(s)" .
  goimports -w .

Updates googleapis#9749
@egonelbre
perf(spanner): avoid duplicated errors.New in UnmarshalJSON
04dd959 
errors.New generates a significant amount of code, however,
the error definition can be easily shared between the implementations.
@egonelbre
fix(spanner): error strings should not be capitalized
f7b3917
@egonelbre egonelbre requested review from a team as code owners August 22, 2024 13:26
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 22, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2024
@rahul2393 rahul2393 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 25, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c342f65 into googleapis:main Sep 25, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 25, 2024
@release-please release-please bot mentioned this pull request Sep 25, 2024
Merged
@egonelbre egonelbre deleted the errors branch September 25, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@egonelbre @rahul2393 @kokoro-team