fix(bigquery): processStream check ctx done when queuing non retryable err #10675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
shollyman
approved these changes
Aug 12, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
Thanks for consolidating the checks, definitely cleans up that process loop a bit.
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When service side returns non-retryable errors faster than they are being consumed by the user (via
Nextcall), theprocessStreamgoroutine can become locked and leak, even when context is cancelled. With this PR, we wrap the call toit.errscall withselectand check for context done.Towards #10672