feat(storage): add full object checksum to reader.Attrs #10538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note - JSON does not currently support returning the checksum for range reads
product-auto-label
bot
added
the
api: storage
BrennaEpp
added
the
do not merge
BrennaEpp
removed
the
do not merge
tritone
approved these changes
Jul 17, 2024
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
Overall looks good, one doc suggestion.
storage/reader.go
Outdated
| // Castagnoli93 polynomial, if available. | ||
| CRC32C uint32 | ||
|
|
||
| // Decompressed is true if the object was read decompressed and different |
Contributor
There was a problem hiding this comment.
This seems a little vague, I would make something that more closely echoes the NewRangeReader docs about transcoding (and/or update those docs to clarify that this field will be True if decompressive transcoding occurs).
tritone
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note - JSON does not currently support returning the checksum for range reads