feat(spanner): Add x-goog-spanner-end-to-end-tracing header for requests to Spanner #10241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nareshz
changed the title
dsimil
reviewed
May 21, 2024
dsimil
reviewed
May 21, 2024
dsimil
approved these changes
May 21, 2024
rahul2393
approved these changes
Jun 5, 2024
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
…into e2e-trace-optin
harshachinta
approved these changes
Jun 12, 2024
nareshz
changed the title
Member
|
@rahul2393 can this be merged? |
Contributor
|
@dsimil Is this ready to be merged. I assume that there is testing going on in backend and this needs to wait until backend is ready? |
…into e2e-trace-optin
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
added
the
do not merge
…into e2e-trace-optin
nareshz
commented
Sep 12, 2024
spanner/client.go
Outdated
| if config.EnableServerSideTracing { | ||
| appendServerSideTracingHeader = true | ||
| } | ||
| if serverSideTracingEnvironmentVariable := os.Getenv("SPANNER_ENABLE_SERVER_SIDE_TRACING"); serverSideTracingEnvironmentVariable == "true" { |
Contributor
Author
There was a problem hiding this comment.
@harshachinta Added the option to enable server side using ENV variable. PTAL.
…into e2e-trace-optin
…into e2e-trace-optin
nareshz
force-pushed
the
e2e-trace-optin
branch
from
b40ec91 to
e86e8b9
Compare
…into e2e-trace-optin
rahul2393
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable tracing on Spanner layer, client can opt-in by following ways:
EnableEndToEndTracingflag in ClientConfig totrue.SPANNER_ENABLE_END_TO_END_TRACINGenvironment variable totrue.If enabled a new http header
x-goog-spanner-end-to-end-tracingwill be passed in Spanner requests.Note: Spanner tracing also requires trace context propagation. This needs to be setup while setting OpenTelemetry.
Design doc: go/cs-tracing-mvp