fix(spanner): wait for background goroutines to complete #10095
Merged
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a good rule of thumb every single goroutine needs to be waited to be completed, otherwise it's easy to introduce issues where the created goroutine outlives the parent and accesses variables or services that have been shutdown.
rahul2393
approved these changes
Jun 5, 2024
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@rahul2393 can we merge this? |
|
@rahul2393 can this be merged? |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a good rule of thumb every single goroutine needs to be waited to be completed, otherwise it's easy to introduce issues where the created goroutine outlives the parent and accesses variables or services that have been shutdown.
Fixes #10324