fix: rename CLOCK_SKEW and separate client/server user case #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Sep 8, 2021
busunkim96
reviewed
Sep 8, 2021
silvolu
approved these changes
Sep 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_helper.CLOCK_SKEWto_helper.REFRESH_THRESHOLD. This value is for client to decide when to refresh a token.clock_skew_in_secondskeyword parameter (default value is 0) tojwt.decode, and remove the hard coded_helper.CLOCK_SKEWin the logic. The reason isjwt.decodeis for server usage to validate iat/exp value. We should leave the clock skew to the server since this is server specific.