Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only add IAM scope to credentials that can change scopes #451

Merged
merged 11 commits into from
Mar 13, 2020
Merged

fix: only add IAM scope to credentials that can change scopes #451

merged 11 commits into from
Mar 13, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 6, 2020 •
edited
Loading

Closes #416.

Users reported that they were no longer able to use user credentials as the parent credential. This was happening because user credentials cannot have their scopes modified after creation.

  • add system test for impersonated credentials
  • update unit test with user credential as donor credential case
  • update CONTRIBUTING.rst with new permissions necessary

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2020
bshaffer
bshaffer reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small implementation suggestion is all I have.

google/auth/impersonated_credentials.py Show resolved Hide resolved
@arithmetic1728
Copy link
Contributor

LGTM

@busunkim96 busunkim96 merged commit 82e224b into master Mar 13, 2020
@tseaver tseaver deleted the impersonated-creds-fix branch October 28, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer left review comments

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking changes for impersonated_credentials between 1.6.3 and 1.7.0+
5 participants
@busunkim96 @arithmetic1728 @bshaffer @googlebot @yoshi-kokoro