-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downscoping to ouath2 credentials #309
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
fixed cla (theoretically) |
CLAs look good, thanks! |
google.auth.app_engine module | ||
============================= | ||
google.auth.app\_engine module | ||
============================== |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google.auth.crypt module | ||
======================== | ||
google.auth.crypt package | ||
========================= |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/credentials.py
Outdated
downscope (bool): Whether to reduce the requested scopes from those | ||
of the refresh token to those listed in scopes. Useful if | ||
refresh token has a wild card scope (e.g. | ||
'https://www.googleapis.com/auth/any-api'). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@eugenewf Note that the tests are passing on CI, so you don't have any work to do to get Python 3.4 working. |
@theacodes Are there any further actions you'd like me to take here? (e.g. with regards to #309 (comment) or #309 (comment)) |
Not at the moment. I just need to find time to review.
…On Thu, Nov 29, 2018 at 3:53 PM Eugene W. Foley ***@***.***> wrote:
@theacodes <https://github.com/theacodes> Are there any further actions
you'd like me to take here? (e.g. with regards to #309 (comment)
<#309 (comment)>
or #309 (comment)
<#309 (comment)>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc_iBT_bMaY42BVSQQY86X-4YkrB9ks5u0HOQgaJpZM4Y0V31>
.
|
google/oauth2/credentials.py
Outdated
@@ -71,6 +71,10 @@ def __init__(self, token, refresh_token=None, id_token=None, | |||
to obtain authorization. This is a purely informative parameter | |||
that can be used by :meth:`has_scopes`. OAuth 2.0 credentials | |||
can not request additional scopes after authorization. | |||
downscope (bool): Whether to reduce the requested scopes from those |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…brary-python Syncing with changes made over the holidays.
…n via classmethods from_authorized_user_info() and from_authorized_user_file()
Apologies for dropping this for so long, I've been rather ill. I had a conversation with Thea back in February resulting in a recommendation to always explicitly request the scopes if they have been provided. I've written that up and added a failure message for the case where the server only grants some of the scopes requested (which is allowed by the oauth spec). Comments appreciated if anyone thinks there's a better way to handle that case :) |
No description provided.