Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create abstract Verifier and Signer, remove key_id hack from App Engine and IAM signers #115

Merged
merged 2 commits into from
Feb 22, 2017
Merged

Create abstract Verifier and Signer, remove key_id hack from App Engine and IAM signers #115

merged 2 commits into from
Feb 22, 2017

Conversation

theacodes
Copy link
Contributor

Resolves #112

@theacodes theacodes added this to the 1.0.0 milestone Feb 17, 2017
dhermes
dhermes reviewed Feb 18, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LG

google/auth/app_engine.py
to :attr:`key_id` and :meth:`sign`. This could result in a signature
that was signed with a different key than the one indicated by
:attr:`key_id`. It's recommended that if you use this in your code
that you account for this behavior by building in retry logic.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/crypt.py Outdated


class RSASigner(Signer):
"""Signs messages with a RSA private key.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/crypt.py Outdated
def __init__(self, private_key, key_id=None):
self._key = private_key
self._key_id = key_id
""""""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Feb 22, 2017

LGTM?

@theacodes
Copy link
Contributor Author

LGTM?

6-anchorman-quotes-burgundy

@theacodes theacodes merged commit 254befe into master Feb 22, 2017
@theacodes theacodes deleted the allow-key-id-none branch February 22, 2017 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@theacodes @dhermes