fix: Conditionally import requests only if no request was passed by the caller. #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arithmetic1728
approved these changes
Jan 19, 2024
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
clundin25
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
cpisunyer
pushed a commit
to cpisunyer/google-auth-library-python
that referenced
this pull request
Jan 22, 2024
…he caller. (googleapis#1456) This resolves https://togithub.com/googleapis/google-auth-library-python/issues/1455. The repo-wide pattern is to only import the requests module at runtime as a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1455.
The repo-wide pattern is to only import the requests module at runtime as a fallback.