fix: fix vm universe_domain bug #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
reviewed
Dec 6, 2023
| @@ -74,6 +75,7 @@ def __init__( | |||
| self._scopes = scopes | |||
| self._default_scopes = default_scopes | |||
| self._universe_domain_cached = False | |||
| self._universe_domain_request = google_auth_requests.Request() | |||
There was a problem hiding this comment.
Why does this request object get saved?
There was a problem hiding this comment.
All req objects are passed in except the one used in the universe_domain property. I am thinking if we need to pass in a custom req object some day, we can override this _universe_domain_request property.
clundin25
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missed a parameter for universe_domain request