Skip to content

fix: Serialize signer keys on __getstate__ for pickling #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 5 commits into from
Oct 5, 2023
Merged

fix: Serialize signer keys on __getstate__ for pickling #1394

gcf-merge-on-green merged 5 commits into from
Oct 5, 2023

Conversation

@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Oct 5, 2023

Fixes #1383

@andrewsg andrewsg requested a review from clundin25 October 5, 2023 18:18
@andrewsg andrewsg requested review from a team as code owners October 5, 2023 18:18
@andrewsg
Merge pull request #1 from clundin25/cred-refresh
3f5af03 
chore: Refresh system test creds.
@clundin25 clundin25 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@andrewsg andrewsg changed the title fix: Serialize RSASigner key on __getstate__ for pickling fix: Serialize signer keys on __getstate__ for pickling Oct 5, 2023
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@clundin25 clundin25 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8b783b9 into googleapis:main Oct 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2023
@release-please release-please bot mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clundin25 clundin25 clundin25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

google.oauth2.service_account.Credential objects are not pickleable if cryptography is installed

3 participants

@andrewsg @clundin25 @yoshi-kokoro