Skip to content

fix: Trust boundary meta header renaming and using the schema from backend team. #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BigTailWolf merged 3 commits into from
Sep 21, 2023
Merged

fix: Trust boundary meta header renaming and using the schema from backend team. #1384

BigTailWolf merged 3 commits into from
Sep 21, 2023

Conversation

@BigTailWolf
Copy link
Contributor

@BigTailWolf BigTailWolf commented Sep 19, 2023

  • A cached self._trust_boundary for service account and external account type is be initialized as "not opt-in" (0x0) of encoded_locations.
  • The meta header is renamed from x-identity-trust-boundary to x-allowed-locations
  • Fix the CI tests accordingly

@BigTailWolf BigTailWolf requested review from a team as code owners September 19, 2023 17:57
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 19, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
TimurSadykov
TimurSadykov approved these changes Sep 20, 2023
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigTailWolf BigTailWolf merged commit 2503d4a into googleapis:main Sep 21, 2023
@BigTailWolf BigTailWolf deleted the b300997411 branch September 21, 2023 16:29
@release-please release-please bot mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsirac lsirac lsirac approved these changes

+1 more reviewer

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BigTailWolf @TimurSadykov @lsirac