Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose universe domain in credentials #1380

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix: expose universe domain in credentials #1380

merged 2 commits into from
Sep 7, 2023

Conversation

arithmetic1728
Copy link
Contributor

Expose universe_domain by adding a property in the credential base class.

@arithmetic1728 arithmetic1728 requested review from a team as code owners September 6, 2023 21:05
@arithmetic1728 arithmetic1728 merged commit 8b8fce6 into main Sep 7, 2023
6 checks passed
@arithmetic1728 arithmetic1728 deleted the expose_universe_domain branch September 7, 2023 17:00
@release-please release-please bot mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arithmetic1728 @sai-sunder-s @clundin25