fix: Skip checking projectid on cred if env var is set #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arithmetic1728
approved these changes
Jul 12, 2023
BigTailWolf
reviewed
Jul 12, 2023
sai-sunder-s
force-pushed
the
byoidprojectid
branch
from
1fd9d1b
to
e166b73
Compare
clundin25
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
lsirac
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For external account credentials, the project id is obtained through an API call and that involves creating a token first. If project id is set already in environment, that is the value that is going to be returned by google.auth.default and the value read through the API is discarded.
Updating logic so that if env var is set, then dont make an API call for project.