feat: add metrics (part 3) #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aeitzman please take a look at the 3PI unit test changes. 3PI credentials use impersonated credentials, since in this PR I added x-goog-api-client header to impersonated credential's refresh method, I made the unit test changes accordingly for this new header. |
clundin25
reviewed
May 25, 2023
clundin25
approved these changes
May 25, 2023
ack - will take a look today |
aeitzman
approved these changes
May 25, 2023
arithmetic1728
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
x-goog-api-clientheader toPrevious PRs:
Part 1: #1298
Part 2: #1303