Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose universe_domain for external account creds #1296

Merged
merged 8 commits into from
May 22, 2023
Merged

feat: expose universe_domain for external account creds #1296

merged 8 commits into from
May 22, 2023

Conversation

BigTailWolf
Copy link
Contributor

No description provided.

@BigTailWolf BigTailWolf requested review from a team as code owners May 17, 2023 23:56
@arithmetic1728 arithmetic1728 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 18, 2023
@lsirac lsirac added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 18, 2023
lsirac
lsirac reviewed May 18, 2023
View reviewed changes
tests/test_external_account.py
@@ -158,6 +159,7 @@ def make_credentials(
quota_project_id=quota_project_id,
scopes=scopes,
default_scopes=default_scopes,
universe_domain=universe_domain,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test retrieving it as well

@lsirac lsirac removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 18, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label May 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 19, 2023
@BigTailWolf BigTailWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023
@BigTailWolf BigTailWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 22, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 22, 2023
@BigTailWolf BigTailWolf merged commit ee07053 into googleapis:main May 22, 2023
@release-please release-please bot mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 left review comments

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@lsirac lsirac lsirac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BigTailWolf @lsirac @arithmetic1728 @clundin25 @yoshi-kokoro