Skip to content

Conversation

@arithmetic1728
Copy link
Contributor

Support universe_domain field from service account json file. The default value is "googleapis.com".

If the value is not default, then
(1) for access token, we will always use self signed jwt flow. Note that domain wide delegation is not supported, so if subject is provided we will throw exceptions.
(2) for id token, we will always use iamcredentials.generateIdToken endpoint. Note that iam.serviceAccountTokenCreator role is required to call this endpoint.

@arithmetic1728 arithmetic1728 requested review from a team as code owners May 6, 2023 05:08
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arithmetic1728 arithmetic1728 merged commit 821c1b6 into main May 10, 2023
@arithmetic1728 arithmetic1728 deleted the universe_domain branch May 10, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants