Skip to content

fix: print out reauth plugin error and raise if challenge output is None #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arithmetic1728 merged 3 commits into from
Mar 30, 2023
Merged

fix: print out reauth plugin error and raise if challenge output is None #1265

arithmetic1728 merged 3 commits into from
Mar 30, 2023

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Mar 30, 2023

  1. print out the reauth plugin in stderr
  2. if we get None from _run_next_challenge, we should just stop and raise a reauth failed error

@arithmetic1728 arithmetic1728 requested review from a team as code owners March 30, 2023 18:53
@arithmetic1728 arithmetic1728 merged commit 08d22fe into main Mar 30, 2023
@arithmetic1728 arithmetic1728 deleted the reauth branch March 30, 2023 20:08
@release-please release-please bot mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clundin25 clundin25 clundin25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arithmetic1728 @clundin25