Skip to content

fix: Python: Remove aws url validation #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BigTailWolf merged 6 commits into from
Mar 24, 2023
Merged

fix: Python: Remove aws url validation #1254

BigTailWolf merged 6 commits into from
Mar 24, 2023

Conversation

@BigTailWolf
Copy link
Contributor

@BigTailWolf BigTailWolf commented Mar 20, 2023

No description provided.

@BigTailWolf BigTailWolf requested review from a team as code owners March 20, 2023 20:41
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2023
@BigTailWolf BigTailWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2023
@BigTailWolf BigTailWolf changed the title fix: Python: Remove awl url validation fix: Python: Remove aws url validation Mar 21, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2023
@arithmetic1728
Copy link
Contributor

arithmetic1728 commented Mar 24, 2023

@BigTailWolf There is a lint error: google/auth/aws.py:50:1: F401 'six.moves.urllib.parse.urlparse' imported but unused
After removing it you can run python -m nox -s lint to verify the problem is fixed.

@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2023
@BigTailWolf BigTailWolf merged commit 20a966b into googleapis:main Mar 24, 2023
@BigTailWolf BigTailWolf deleted the b270449772 branch March 24, 2023 21:15
@release-please release-please bot mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsirac lsirac lsirac approved these changes

+1 more reviewer

@clundin25 clundin25 clundin25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BigTailWolf @arithmetic1728 @lsirac @clundin25 @yoshi-kokoro