fix: don't retry if error or error_description is not string #1241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users forget to set quota project id in user credential ADC file, and reauth is needed, the server returns the following error:
Note that the 'error' value is not a string, so the
if any(e in retryable_error_descriptions for e in (error_code, error_desc))
line throws an exception sayingunhashable type: 'dict'
. We should simply return if either error or error_description is not a string.Internal bug: b/270627288
This PR also fixes a flaky sample test by setting a 10 seconds clock skew when verifying id token.