Skip to content

fix: Improve ADC related errors and warnings #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arithmetic1728 merged 3 commits into from
Feb 28, 2023
Merged

fix: Improve ADC related errors and warnings #1237

arithmetic1728 merged 3 commits into from
Feb 28, 2023

Conversation

@wangyutongg
Copy link
Contributor

@wangyutongg wangyutongg commented Feb 25, 2023 •
edited
Loading

Fix #1235

  1. Improve the ADC missing error when default credentials are not set up.
  2. Improve the warning message when developers user user credential without setting up quota project. This could happen in both prod and local dev environment.

@wangyutongg wangyutongg marked this pull request as ready for review February 27, 2023 22:21
@wangyutongg wangyutongg requested review from a team as code owners February 27, 2023 22:21
@arithmetic1728 arithmetic1728 merged commit 2dfa213 into main Feb 28, 2023
@arithmetic1728 arithmetic1728 deleted the yutong-adc-errors branch February 28, 2023 03:00
@release-please release-please bot mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsirac lsirac lsirac approved these changes

+1 more reviewer

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve local user experience for User Credentials

3 participants

@wangyutongg @lsirac @arithmetic1728